Skip to content

[PWGDQ] New muon ML method and implementation in tableMaker#13107

Merged
lucamicheletti93 merged 8 commits intoAliceO2Group:masterfrom
mcoquet642:dq-ml-matching-full
Sep 25, 2025
Merged

[PWGDQ] New muon ML method and implementation in tableMaker#13107
lucamicheletti93 merged 8 commits intoAliceO2Group:masterfrom
mcoquet642:dq-ml-matching-full

Conversation

@mcoquet642
Copy link
Collaborator

@mcoquet642 mcoquet642 commented Sep 23, 2025

  • Adding new ML model filling method "getInputFeaturesGlob"
  • Corresponding implementation in tableMaker in the new function "skimBestMuonMatchesML".
  • Implementing "FwdToTrackPar" function to convert AO2D FwdTracks to TrackParFwd format, to avoid code duplication.
  • Port muon ML implementation to tableMaker for data

@github-actions github-actions bot added the pwgdq label Sep 23, 2025
@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

O2 linter results: ❌ 874 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Sep 24, 2025
Merged
@mcoquet642
Merge pull request #22 from alibuild/alibot-cleanup-13107
f54c505 
Please consider the following formatting changes to AliceO2Group#13107
@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) September 24, 2025 09:14
@alibuild
Copy link
Collaborator

alibuild commented Sep 24, 2025

Error while checking build/O2Physics/o2 for c3523c7 at 2025-09-24 16:56:

## sw/BUILD/O2Physics-latest/log
input_line_9:1823:1: error: expected expression
/sw/slc9_x86-64/ROOT/v6-32-06-alice10-local1/include/THashList.h:72:4: error: static data member 'fgIsA' not allowed in local class 'THashList'
input_line_9:6053:3: error: static data member 'fgIsA' not allowed in local class 'HistogramManager'
/usr/include/inttypes.h:266:1: error: expected unqualified-id
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/rapidjson.h:378:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/rapidjson.h:389:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/rapidjson.h:641:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/allocators.h:20:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/encodings.h:30:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/stream.h:22:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/memorystream.h:26:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/encodedstream.h:31:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/internal/meta.h:35:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/internal/swap.h:25:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/internal/stack.h:27:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/internal/ieee754.h:20:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/internal/biginteger.h:25:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/internal/diyfp.h:31:1: error: namespaces can only be defined in global or namespace scope
/sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include/rapidjson/internal/pow10.h:20:1: error: namespaces can only be defined in global or namespace scope
Error: /sw/slc9_x86-64/ROOT/v6-32-06-alice10-local1/bin/rootcling: compilation failure (/sw/BUILD/985d597e71d3215a1ef0f0e6f31c3079cc83dbae/O2Physics/PWGDQ/Core/G__O2PhysicsPWGDQCore49e856972a_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

@lucamicheletti93 lucamicheletti93 merged commit 66b051f into AliceO2Group:master Sep 25, 2025
9 of 11 checks passed
@vkucera
Copy link
Collaborator

vkucera commented Sep 25, 2025

@mcoquet642 @lucamicheletti93 Please don't ignore reported errors.

jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025
@mcoquet642 @alibuild @jmunozme
[PWGDQ] New muon ML method and implementation in tableMaker (AliceO2G…
0ded501 
…roup#13107)

Co-authored-by: Maurice Coquet <mcoquet@lxplus964.cern.ch>
Co-authored-by: Maurice Coquet <mcoquet@lxplus990.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@mcoquet642 @alibuild @jinhyunni
[PWGDQ] New muon ML method and implementation in tableMaker (AliceO2G…
6671bee 
…roup#13107)

Co-authored-by: Maurice Coquet <mcoquet@lxplus964.cern.ch>
Co-authored-by: Maurice Coquet <mcoquet@lxplus990.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@mcoquet642 @alibuild @ThePhDane
[PWGDQ] New muon ML method and implementation in tableMaker (AliceO2G…
229df74 
…roup#13107)

Co-authored-by: Maurice Coquet <mcoquet@lxplus964.cern.ch>
Co-authored-by: Maurice Coquet <mcoquet@lxplus990.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@mcoquet642 @alibuild @jloemker
[PWGDQ] New muon ML method and implementation in tableMaker (AliceO2G…
710654a 
…roup#13107)

Co-authored-by: Maurice Coquet <mcoquet@lxplus964.cern.ch>
Co-authored-by: Maurice Coquet <mcoquet@lxplus990.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucamicheletti93 lucamicheletti93 lucamicheletti93 approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

Assignees

No one assigned

Labels

pwgdq

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcoquet642 @alibuild @vkucera @lucamicheletti93

Comments